Problem removing cells from tableview

japs · June 2012

I´m having a problem when trying to delete the right row in my tableview. I have 3 dynamic created cells grouped, and also, i´m using the editing mode. Everything is working fine when adding more rows in each section, but when i try to delete a specific row in a specific section, it does´t work correctly. Let´s say that i have added rows 1,2,3 (besides de original one) and i want to delete number 2, it works for the first time, but then it gets stuck!!. I have also a method that gives automatically a tag for each new row created.
I think my problem is that the row.tag in the tableview are not matching with the ones in my array(i have an array receiving the inserted cells, and it should work with the deleted ones!!!). Here is my code:


- (void)tableView:(UITableView *)TableView commitEditingStyle:(UITableViewCellEditingStyle)editingStyle 
forRowAtIndexPath:(NSIndexPath *)indexPath 
{
	
    if (editingStyle == UITableViewCellEditingStyleDelete) 
{
         
   int i=0;
   for (i=0; i<myarray.count; i++)
   {
     UITableViewCell *aux=[myarray objectAtIndex:i];
     UITableViewCell* myCell = (UITableViewCell *)[(UITableView *)TableView cellForRowAtIndexPath:indexPath];
             
      if (aux.tag == myCell.tag) 
      {
        [TableView beginUpdates]; 
        [myarray removeObjectAtIndex:i];
        [TableView deleteRowsAtIndexPaths:[NSArray arrayWithObject:indexPath]withRowAnimation:UITableViewRowAnimationFade];
        [TableView endUpdates];

What am i doing wrong? how can i match the deleted rows in the tableview and in the array at the same time?

Thanks

BrianSlick · June 2012

There is no reason to keep an array of cells. You might want to read through the table view link in my signature.

japs · June 2012

BrianSlick;438553 said:
There is no reason to keep an array of cells. You might want to read through the table view link in my signature.

Hello Brian

First of all let me thank you for replying to my post, your tutorials are great!!. But i don´t understand why do you say not to keep an array of cells and then in your tutorials you write:

We will remove a row, therefore we must remove something from the array at the same time.


- (void)tableView:(UITableView *)tableView
commitEditingStyle:(UITableViewCellEditingStyle)editingStyle
forRowAtIndexPath:(NSIndexPath *)indexPath
{
   if (editingStyle == UITableViewCellEditingStyleDelete)
   {
      [[self contents] removeObjectAtIndex:[indexPath row]];

      NSArray *indexPathsToRemove = [NSArray arrayWithObject:indexPath];

      [tableView deleteRowsAtIndexPaths:indexPathsToRemove withRowAnimation:UITableViewRowAnimationRight]; }
}

What am i missing?!

Thanks again

BrianSlick · June 2012

That array doesn't hold cells. I don't see what the confusion is.

japs · June 2012

BrianSlick;438786 said:
That array doesn't hold cells. I don't see what the confusion is.

Hello Brian

Thanks for answering, i think i need to show you some more of my code:

I have inserting new cells like this:

else if (editingStyle == UITableViewCellEditingStyleInsert)
{
switch(indexPath.section)
{
case 0:
if(indexPath.row==0 && indexPath.section==0)
{
static NSString *cellType1 = @"cellType1";
UITableViewCell *cell = [TableView dequeueReusableCellWithIdentifier:cellType1];
cell.tag=[self Maxtaginsection:0];
[myarray insertObject:cell atIndex:[myarray count]];
[Table reloadData];

}
break;

case 1:
if(indexPath.row==0 && indexPath.section==1)
{
static NSString *cellType2= @"cellType2";
UITableViewCell *cell = [TableView dequeueReusableCellWithIdentifier:cellType2];
cell.tag=[self Maxtaginsection:1];
[myarray insertObject:cell atIndex:[myarray count]];
[Table reloadData];
}
break;

etc....

i´m giving a tag for each new cell like this:

- (NSInteger) Maxtaginsection:(NSInteger)section
{

int i=0,Maxtag=0;

for (i=0; i < myarray.count; i++) {
UITableViewCell *aux=[myarray objectAtIndex:i];

if (aux.tag >= 100 && aux.tag < 200 && section==0) {
if(Maxtag < aux.tag)
Maxtag=aux.tag;
}
if (aux.tag >= 200 && aux.tag < 300 && section==1) {
if(Maxtag < aux.tag)
Maxtag=aux.tag;
}
if (aux.tag >= 300 && section==2) {
if(Maxtag < aux.tag)
Maxtag=aux.tag;
}

}

return Maxtag+1;
}

Should i stop inserting cells in a array?. (sorry, newbie)!.

BrianSlick · June 2012

japs;439457 said:
Should i stop inserting cells in a array?

BrianSlick;438553 said:
There is no reason to keep an array of cells. You might want to read through the table view link in my signature.

.

Howdy, Stranger!

Forums

Problem removing cells from tableview

Replies